HomePhabricator

Be less strict when detecting dead daemons

Description

Be less strict when detecting dead daemons

Summary:
Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan:

  • Faked an exception for all tasks.
  • Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
  • After patch: daemon setup error no longer triggers.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12306

Differential Revision: https://secure.phabricator.com/D17397

Details

Provenance
epriestleyAuthored on Feb 22 2017, 10:05 PM
epriestleyPushed on Feb 22 2017, 10:11 PM
Reviewer
chad
Differential Revision
D17397: Be less strict when detecting dead daemons
Parents
rP6f50729a9171: Update Phabricator for new daemon pool changes
Branches
Unknown
Tags
Unknown
Tasks
T12306: Failing svn connection brings daemon down
Build Status
Buildable 15731
Build 20786: Run Core Tests