Page MenuHomePhabricator

Be less strict when detecting dead daemons
ClosedPublic

Authored by epriestley on Feb 22 2017, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 11 2026, 3:16 PM
Unknown Object (File)
Mar 8 2026, 10:34 AM
Unknown Object (File)
Feb 11 2026, 12:10 AM
Unknown Object (File)
Feb 6 2026, 8:31 PM
Unknown Object (File)
Jan 14 2026, 3:02 AM
Unknown Object (File)
Dec 23 2025, 8:11 AM
Unknown Object (File)
Dec 2 2025, 12:58 AM
Unknown Object (File)
Dec 1 2025, 6:42 AM
Subscribers
None

Details

Summary

Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan
  • Faked an exception for all tasks.
  • Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
  • After patch: daemon setup error no longer triggers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable