Page MenuHomePhabricator

Be less strict when detecting dead daemons
ClosedPublic

Authored by epriestley on Feb 22 2017, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 4:40 AM
Unknown Object (File)
Tue, Jan 14, 12:16 PM
Unknown Object (File)
Fri, Dec 20, 9:33 PM
Unknown Object (File)
Fri, Dec 20, 5:14 PM
Unknown Object (File)
Fri, Dec 20, 11:46 AM
Unknown Object (File)
Dec 18 2024, 2:19 PM
Unknown Object (File)
Dec 18 2024, 12:48 PM
Unknown Object (File)
Dec 18 2024, 12:36 PM
Subscribers
None

Details

Summary

Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan
  • Faked an exception for all tasks.
  • Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
  • After patch: daemon setup error no longer triggers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable