Page MenuHomePhabricator

Be less strict when detecting dead daemons
ClosedPublic

Authored by epriestley on Feb 22 2017, 10:09 PM.
Tags
None
Referenced Files
F18344257: D17397.diff
Tue, Aug 26, 9:23 AM
F18102379: D17397.diff
Sat, Aug 9, 8:23 PM
F18102302: D17397.id41834.diff
Sat, Aug 9, 7:54 PM
F18094377: D17397.id.diff
Thu, Aug 7, 10:06 PM
F17970284: D17397.id41832.diff
Fri, Aug 1, 2:40 PM
F17833226: D17397.id41832.diff
Jul 26 2025, 1:23 PM
F17808151: D17397.id41834.diff
Jul 25 2025, 3:40 PM
F17805952: D17397.id.diff
Jul 25 2025, 1:14 PM
Subscribers
None

Details

Summary

Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan
  • Faked an exception for all tasks.
  • Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
  • After patch: daemon setup error no longer triggers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable