Page MenuHomePhabricator

Be less strict when detecting dead daemons
ClosedPublic

Authored by epriestley on Feb 22 2017, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 11:33 AM
Unknown Object (File)
Mon, Apr 8, 10:51 AM
Unknown Object (File)
Mon, Apr 1, 4:40 PM
Unknown Object (File)
Sun, Mar 31, 1:17 AM
Unknown Object (File)
Tue, Mar 26, 2:44 AM
Unknown Object (File)
Fri, Mar 22, 2:13 PM
Unknown Object (File)
Wed, Mar 20, 4:40 AM
Unknown Object (File)
Mar 19 2024, 5:58 PM
Subscribers
None

Details

Summary

Fixes T12306. Currently, we warn about daemons not running even if they're in normal "alive" states, particularly "waiting to restart after a failure".

This check was made more strict in D12088, back when we tried to version check running daemons. Since we implemented auto-restart-after-config-change we don't do this anymore, so it should be fine to make this more lax again.

Test Plan
  • Faked an exception for all tasks.
  • Before patch: reloading the daemon setup error sometimes raised a false positive ("waiting" daemon detected as dead).
  • After patch: daemon setup error no longer triggers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable