Ref T7149. Return a real iterator from the Chunk engine, which processes chunks sequentially.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T7149: Allow users to import data into a new Phacility instance
- Commits
- Restricted Diffusion Commit
rPc19bb57730a2: Stream chunks when sending chunked files
This is a bit hard to read, but shows the underlying chunks being accessed one at a time and only some being accessed when requesting a range of a file:
$ ./bin/files cat F878 --trace --begin 100 --end 256 ... >>> [10] <query> SELECT * FROM `file_storageblob` WHERE `id` = 85 <<< [10] <query> 240 us better software. Phabricat>>> [11] <query> SELECT * FROM `file_storageblob` WHERE `id` = 84 <<< [11] <query> 205 us or includes applications for: >>> [12] <query> SELECT * FROM `file_storageblob` WHERE `id` = 83 <<< [12] <query> 226 us - reviewing and auditing source>>> [13] <query> SELECT * FROM `file_storageblob` WHERE `id` = 82 <<< [13] <query> 203 us code; - hosting and browsing >>> [14] <query> SELECT * FROM `file_storageblob` WHERE `id` = 81 <<< [14] <query> 231 us repositories; - tracking bugs;
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- chunk8
- Lint
Lint Errors Severity Location Code Message Error src/applications/files/engine/PhabricatorFileChunkIterator.php:5 XHP45 PHP Compatibility - Unit
Tests Passed - Build Status
Buildable 4879 Build 4897: [Placeholder Plan] Wait for 30 Seconds