Page MenuHomePhabricator

Stream chunks when sending chunked files
ClosedPublic

Authored by epriestley on Mar 13 2015, 9:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 5:34 AM
Unknown Object (File)
Sun, Mar 10, 10:00 AM
Unknown Object (File)
Feb 14 2024, 7:53 AM
Unknown Object (File)
Feb 14 2024, 7:52 AM
Unknown Object (File)
Feb 14 2024, 7:52 AM
Unknown Object (File)
Feb 7 2024, 3:13 PM
Unknown Object (File)
Feb 3 2024, 2:30 AM
Unknown Object (File)
Dec 18 2023, 10:49 AM

Details

Summary

Ref T7149. Return a real iterator from the Chunk engine, which processes chunks sequentially.

Test Plan

This is a bit hard to read, but shows the underlying chunks being accessed one at a time and only some being accessed when requesting a range of a file:

$ ./bin/files cat F878 --trace --begin 100 --end 256
...
>>> [10] <query> SELECT * FROM `file_storageblob` WHERE `id` = 85
<<< [10] <query> 240 us
 better software.

Phabricat>>> [11] <query> SELECT * FROM `file_storageblob` WHERE `id` = 84
<<< [11] <query> 205 us
or includes applications for:

 >>> [12] <query> SELECT * FROM `file_storageblob` WHERE `id` = 83
<<< [12] <query> 226 us
 - reviewing and auditing source>>> [13] <query> SELECT * FROM `file_storageblob` WHERE `id` = 82
<<< [13] <query> 203 us
 code;
  - hosting and browsing >>> [14] <query> SELECT * FROM `file_storageblob` WHERE `id` = 81
<<< [14] <query> 231 us
repositories;
  - tracking bugs;

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Stream chunks when sending chunked files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2015, 10:36 PM
This revision was automatically updated to reflect the committed changes.