Page MenuHomePhabricator
Differential D12063

Add support for partially uploaded files
ClosedPublic
Actions

Authored by epriestley on Mar 13 2015, 2:09 AM.
Tags
None
Referenced Files
F13172394: D12063.diff
Tue, May 7, 3:24 PM
Unknown Object (File)
Fri, May 3, 1:37 PM
Unknown Object (File)
Fri, May 3, 4:55 AM
Unknown Object (File)
Thu, May 2, 9:49 AM
Unknown Object (File)
Sat, Apr 27, 8:10 PM
Unknown Object (File)
Thu, Apr 25, 12:41 AM
Unknown Object (File)
Thu, Apr 11, 7:31 PM
Unknown Object (File)
Apr 3 2024, 5:43 AM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T7149: Allow users to import data into a new Phacility instance
Commits
Restricted Diffusion Commit
rPaa4adf3ab870: Add support for partially uploaded files
Summary

Ref T7149. This flags allocated but incomplete files and doesn't explode when trying to download them.

Files are marked complete when the last chunk is uploaded.

I added a key on <authorPHID, isPartial> so we can show you a list of partially uploaded files and prompt you to resume them at some point down the road.

Test Plan

Massaged debugging settings and uploaded README.md very slowly in 32b chunks. Saw the file lose its "Partial" flag when the last chunk finished.

Diff Detail

Repository
rP Phabricator
Branch
chunk3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4869
Build 4887: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29031.Mar 13 2015, 2:09 AM
epriestley retitled this revision from to Add support for partially uploaded files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7149: Allow users to import data into a new Phacility instance.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 13 2015, 2:09 AM
joshuaspence added a subscriber: joshuaspence.Mar 13 2015, 3:51 AM
btrahan accepted this revision.Mar 13 2015, 6:08 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2015, 6:08 PM
Closed by commit rPaa4adf3ab870: Add support for partially uploaded files (authored by epriestley, committed by epriestley). · Explain WhyMar 13 2015, 6:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29031

View Options

resources/sql/autopatches/20150312.filechunk.2.sql

Loading...
View Options

resources/sql/autopatches/20150312.filechunk.3.sql

Loading...
View Options

src/applications/files/conduit/FileAllocateConduitAPIMethod.php

Loading...
View Options

src/applications/files/conduit/FileConduitAPIMethod.php

Loading...
View Options

src/applications/files/conduit/FileUploadChunkConduitAPIMethod.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/query/PhabricatorFileChunkQuery.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
Phabricator · Built by Phacility