Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T6840: Repository imported with some commits missing Herald step
- Commits
- Restricted Diffusion Commit
rP6a60b8cb6f2b: Set "importStatus" as nonmutable on save()
Verified all references to importStatus are either:
- SQL patches creating the column;
- reads;
- writes immediately before an insert; or
- explicit updates of the column.
That is, I identified no cases of setImportStatus(X)->save() on a Commit which may already exist. This would break that.
In general, almost all writes go through $commit->writeImportStatusFlag(), which is an explicit update.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable