Page MenuHomePhabricator

Set "importStatus" as nonmutable on save()
ClosedPublic

Authored by epriestley on Feb 19 2015, 3:41 PM.
Tags
None
Referenced Files
F15468403: D11823.id28494.diff
Fri, Apr 4, 12:19 AM
F15433305: D11823.id.diff
Mon, Mar 24, 10:32 PM
F15428803: D11823.id28494.diff
Sun, Mar 23, 10:28 PM
F15428471: D11823.id28507.diff
Sun, Mar 23, 8:34 PM
F15426100: D11823.id.diff
Sun, Mar 23, 7:06 AM
F15424176: D11823.id28507.diff
Sat, Mar 22, 8:41 PM
F15421021: D11823.diff
Fri, Mar 21, 8:19 PM
F15343975: D11823.id28494.diff
Mon, Mar 10, 2:15 AM
Subscribers

Details

Summary

Fixes T6840. Depends on D11822, which is a little iffy.

Test Plan

Verified all references to importStatus are either:

  • SQL patches creating the column;
  • reads;
  • writes immediately before an insert; or
  • explicit updates of the column.

That is, I identified no cases of setImportStatus(X)->save() on a Commit which may already exist. This would break that.

In general, almost all writes go through $commit->writeImportStatusFlag(), which is an explicit update.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Set "importStatus" as nonmutable on save().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2015, 6:31 PM
This revision was automatically updated to reflect the committed changes.