HomePhabricator

Set "importStatus" as nonmutable on save()

Description

Set "importStatus" as nonmutable on save()

Summary: Fixes T6840. Depends on D11822, which is a little iffy.

Test Plan:
Verified all references to importStatus are either:

  • SQL patches creating the column;
  • reads;
  • writes immediately before an insert; or
  • explicit updates of the column.

That is, I identified no cases of setImportStatus(X)->save() on a Commit which may already exist. This would break that.

In general, almost all writes go through $commit->writeImportStatusFlag(), which is an explicit update.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6840

Differential Revision: https://secure.phabricator.com/D11823

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Feb 19 2015, 6:36 PM
Reviewer
btrahan
Differential Revision
D11823: Set "importStatus" as nonmutable on save()
Parents
rP751ffe123dc2: Support HTTP Strict Transport Security
Branches
Unknown
Tags
Unknown
Tasks
T6840: Repository imported with some commits missing Herald step