Differential D11793

OAuth - make sure users know they are exposing their primary email address
ClosedPublic
Actions

Authored by btrahan on Feb 17 2015, 10:18 PM.

Tags

None

Referenced Files

	F13259422: D11793.id28427.diff
	Sun, May 26, 8:20 PM

	F13234479: D11793.diff
	Tue, May 21, 3:27 AM

	F13225063: D11793.id.diff
	Sun, May 19, 1:15 PM

	F13212472: D11793.diff
	Fri, May 17, 6:45 AM

	F13197356: D11793.diff
	Mon, May 13, 12:07 AM

	Unknown Object (File)
	Fri, May 3, 9:20 AM

	Unknown Object (File)
	Wed, May 1, 5:21 AM

	Unknown Object (File)
	Wed, May 1, 5:21 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7263: OAuth prefills username as real name on instances

Commits

Restricted Diffusion Commit
rP17ced84ace33: OAuth - make sure users know they are exposing their primary email address

Summary

Fixes T7263. Last bit there was to upgrade this dialogue to let users know they are letting their primary email address be exposed in these flows. Depends on D11791, D11792, at least in terms of being accurate to the user as the code ended up strangely decoupled.

Test Plan

wordsmithin'

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28427.Feb 17 2015, 10:18 PM

btrahan added a task: T7263: OAuth prefills username as real name on instances.

btrahan retitled this revision from to OAuth - make sure users know they are exposing their primary email address.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added parent revisions: D11792: Phabricator OAuth - tweak Phabricator Oauth adapter, D11791: Conduit - return primary email if its verified in user methods.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 17 2015, 10:18 PM

Works for me.

This revision is now accepted and ready to land.Feb 17 2015, 10:18 PM

Closed by commit rP17ced84ace33: OAuth - make sure users know they are exposing their primary email address (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 10:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

oauthserver/

controller/

PhabricatorOAuthServerAuthController.php

3 lines

Diff 28428

src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php

Loading...