Page MenuHomePhabricator

OAuth prefills username as real name on instances
Closed, ResolvedPublic

Description

When you sign up for an account, we prefill your real name using your upstream username, which is silly.

Event Timeline

epriestley raised the priority of this task from to Needs Triage.
epriestley updated the task description. (Show Details)
epriestley added a project: Phacility.
epriestley moved this task to v0 Closed Beta on the Phacility board.
epriestley added a subscriber: epriestley.

When you oauth between instances, the registration form prefills your username on the remote instance as your "Real name" on the local instance. This is probably just a copy/paste issue somewhere in the Adapter in libphutil.

I think we should also expose primary emails over OAuth: this will make the workflow a lot easier in Phacility, and I think it's consistent with expectations (other OAuth providers expose email addresses):

  • If it's verified, return primary email address from calls to user.whoami.
  • Have the adapter read it.
  • Maybe tweak the "Authorize Application" text to be like "basic information, including your primary email address", to be clear to users? This might be soften-able / humanizable to make the flow more friendly in a Phacility context without losing generality, too.

When we create an OAuth provider on instances we already flag it as trusting the email addresses it receives, so that should be sufficient to get everything prefilling correctly and just let users click "Yes" buttons until they're done.

epriestley renamed this task from OAuth prefills username as real name on isntances to OAuth prefills username as real name on instances.Feb 15 2015, 3:28 PM