Page MenuHomePhabricator
Differential D11791

Conduit - return primary email if its verified in user methods
ClosedPublic
Actions

Authored by btrahan on Feb 17 2015, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 10:42 PM
Unknown Object (File)
Tue, Dec 17, 12:33 AM
Unknown Object (File)
Tue, Dec 10, 1:55 PM
Unknown Object (File)
Fri, Dec 6, 10:21 PM
Unknown Object (File)
Wed, Dec 4, 6:03 PM
Unknown Object (File)
Sat, Nov 30, 12:56 AM
Unknown Object (File)
Thu, Nov 28, 6:07 PM
Unknown Object (File)
Wed, Nov 27, 3:44 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7263: OAuth prefills username as real name on instances
Commits
Restricted Diffusion Commit
rPd6bbbcb620e3: Conduit - return primary email if its verified in user methods
Summary

Ref T7263. We need this in the oauth case and otherwise it makes sense to include.

Test Plan

used the conduit console and saw my email address included in the results!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28423.Feb 17 2015, 10:11 PM
btrahan added a task: T7263: OAuth prefills username as real name on instances.
btrahan retitled this revision from to Conduit - return primary email if its verified in user methods.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 17 2015, 10:11 PM
btrahan added a child revision: D11792: Phabricator OAuth - tweak Phabricator Oauth adapter.Feb 17 2015, 10:13 PM
epriestley accepted this revision.Feb 17 2015, 10:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2015, 10:13 PM
Closed by commit rPd6bbbcb620e3: Conduit - return primary email if its verified in user methods (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 10:13 PM
This revision was automatically updated to reflect the committed changes.
btrahan added a child revision: D11793: OAuth - make sure users know they are exposing their primary email address.Feb 17 2015, 10:18 PM
epriestley mentioned this in D12848: Fix an issue with user.whoami.May 14 2015, 10:49 PM
epriestley mentioned this in rP705c1e649872: Fix an issue with user.whoami.May 14 2015, 11:49 PM
chad mentioned this in T10279: Allow bot users to see email addresses of users.Feb 5 2016, 9:49 PM

Revision Contents
Changeset List

PathSize
src/
applications/
people/
conduit/
15 lines

Diff 28425

View Options

src/applications/people/conduit/UserConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility