Page MenuHomePhabricator
Differential D11792

Phabricator OAuth - tweak Phabricator Oauth adapter
ClosedPublic
Actions

Authored by btrahan on Feb 17 2015, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:30 AM
Unknown Object (File)
Sat, Nov 16, 2:44 AM
Unknown Object (File)
Thu, Nov 14, 5:15 AM
Unknown Object (File)
Tue, Nov 12, 5:46 AM
Unknown Object (File)
Mon, Nov 11, 4:19 PM
Unknown Object (File)
Fri, Nov 8, 7:05 AM
Unknown Object (File)
Sun, Nov 3, 7:44 PM
Unknown Object (File)
Sat, Nov 2, 11:25 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7263: OAuth prefills username as real name on instances
Commits
rPHUe99f07349e7d: Phabricator OAuth - tweak Phabricator Oauth adapter
Summary

Ref T7263. We should use "realName" for the real name and now that we have primary email lets use that too. Depends on D11791.

Test Plan

you just gotta believe in the power of the abstractions

Diff Detail

Repository
rPHU libphutil
Branch
T7263
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4525
Build 4539: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28424.Feb 17 2015, 10:13 PM
btrahan added a task: T7263: OAuth prefills username as real name on instances.
btrahan retitled this revision from to Phabricator OAuth - tweak Phabricator Oauth adapter.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a parent revision: D11791: Conduit - return primary email if its verified in user methods.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 17 2015, 10:13 PM
epriestley accepted this revision.Feb 17 2015, 10:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2015, 10:13 PM
Closed by commit rPHUe99f07349e7d: Phabricator OAuth - tweak Phabricator Oauth adapter (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 10:14 PM
This revision was automatically updated to reflect the committed changes.
btrahan added a child revision: D11793: OAuth - make sure users know they are exposing their primary email address.Feb 17 2015, 10:18 PM

Revision Contents
Changeset List

PathSize
src/
auth/
4 lines

Diff 28424

View Options

src/auth/PhutilPhabricatorAuthAdapter.php

Loading...
Phabricator · Built by Phacility