Page MenuHomePhabricator

Fix an issue with user.whoami
ClosedPublic

Authored by epriestley on May 14 2015, 10:49 PM.
Tags
None
Referenced Files
F15461979: D12848.id30914.diff
Tue, Apr 1, 12:42 PM
F15430131: D12848.id30912.diff
Mon, Mar 24, 5:49 AM
F15424636: D12848.id.diff
Sat, Mar 22, 11:27 PM
F15403398: D12848.diff
Tue, Mar 18, 3:10 AM
F15385778: D12848.id.diff
Fri, Mar 14, 11:23 PM
F15377980: D12848.diff
Thu, Mar 13, 11:48 AM
Unknown Object (File)
Feb 13 2025, 9:21 PM
Unknown Object (File)
Feb 8 2025, 4:33 AM
Subscribers

Details

Summary

Both user.whoami and user.query call the same wire formatting code, but expect different data.

Don't try to add availability data to user.whoami.

Stop adding email data to user.query. We've added it since D11791, but my intent was for it to be exposed only via user.whoami (i.e., expose your address, not others').

Test Plan
  • Called both methods.
  • Saw emails on user.whoami.
  • Saw availability on user.query.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with user.whoami.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 11:44 PM
This revision was automatically updated to reflect the committed changes.