Page MenuHomePhabricator

Add abstract `getGroup()` method
ClosedPublic

Authored by joshuaspence on Feb 12 2015, 7:33 AM.
Tags
None
Referenced Files
F15539773: D11756.diff
Fri, Apr 25, 4:14 AM
F15440369: D11756.id28340.diff
Mar 26 2025, 12:27 PM
F15437226: D11756.id28699.diff
Mar 25 2025, 6:26 PM
F15429920: D11756.id28340.diff
Mar 24 2025, 4:53 AM
F15426108: D11756.diff
Mar 23 2025, 7:13 AM
F15413566: D11756.diff
Mar 19 2025, 7:42 PM
F15392952: D11756.diff
Mar 15 2025, 6:37 PM
F15362353: D11756.diff
Mar 11 2025, 12:48 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPeec2d145df03: Add abstract `getGroup()` method
Summary

In D11722, a getGroup() method was added to all subclasses of PhabricatorApplicationConfigOptions, but no abstract method was added to the base class. This will fail if a custom *ConfigOptions class does not provide a getGroup() method, in which case $group->getGroup() (in PhabricatorConfigListController) will fatal.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4477
Build 4491: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Add abstract `getGroup()` method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 28 2015, 9:55 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
This revision was automatically updated to reflect the committed changes.