HomePhabricator

Add abstract `getGroup()` method

Description

Add abstract getGroup() method

Summary: In D11722, a getGroup() method was added to all subclasses of PhabricatorApplicationConfigOptions, but no abstract method was added to the base class. This will fail if a custom *ConfigOptions class does not provide a getGroup() method, in which case $group->getGroup() (in PhabricatorConfigListController) will fatal.

Test Plan: N/A

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11756

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Feb 28 2015, 10:47 PM
Reviewer
Blessed Reviewers
Differential Revision
D11756: Add abstract `getGroup()` method
Parents
rPea337abafb67: Minor tidying of `lipsum generate` workflow
Branches
Unknown
Tags
Unknown