Paths

Table of Contentst

Differential D11756

Add abstract `getGroup()` method
ClosedPublic
Actions

Authored by joshuaspence on Feb 12 2015, 7:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 13 2024, 7:02 PM

	Unknown Object (File)
	Dec 8 2024, 5:39 PM

	Unknown Object (File)
	Dec 5 2024, 12:37 PM

	Unknown Object (File)
	Nov 29 2024, 12:56 PM

	Unknown Object (File)
	Nov 20 2024, 8:29 PM

	Unknown Object (File)
	Nov 19 2024, 9:26 PM

	Unknown Object (File)
	Nov 16 2024, 4:49 AM

	Unknown Object (File)
	Nov 12 2024, 3:50 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPeec2d145df03: Add abstract `getGroup()` method

Summary

In D11722, a getGroup() method was added to all subclasses of PhabricatorApplicationConfigOptions, but no abstract method was added to the base class. This will fail if a custom *ConfigOptions class does not provide a getGroup() method, in which case $group->getGroup() (in PhabricatorConfigListController) will fatal.

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28340.Feb 12 2015, 7:33 AM

joshuaspence retitled this revision from to Add abstract `getGroup()` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 12 2015, 7:33 AM

Herald added a subscriber: epriestley. · View Herald Transcript

WIP?

This revision is now accepted and ready to land.Feb 28 2015, 9:55 PM

joshuaspence updated this object.Feb 28 2015, 10:44 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

joshuaspence updated this object.Feb 28 2015, 10:46 PM

Closed by commit rPeec2d145df03: Add abstract `getGroup()` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 28 2015, 10:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorApplicationConfigOptions.php

1 line

Diff 28699

src/applications/config/option/PhabricatorApplicationConfigOptions.php

Loading...