Paths

Table of Contentst

Differential D11747

Update Phabricator to work with more modular translations
ClosedPublic
Actions

Authored by epriestley on Feb 11 2015, 8:23 PM.

Tags

None

Referenced Files

	F14070651: D11747.diff
	Wed, Nov 20, 1:34 PM

	F14048316: D11747.id28316.diff
	Thu, Nov 14, 7:27 AM

	F13995745: D11747.id28322.diff
	Wed, Oct 23, 3:08 PM

	F13962218: D11747.id28316.diff
	Oct 15 2024, 8:52 AM

	Unknown Object (File)
	Oct 1 2024, 2:17 PM

	Unknown Object (File)
	Sep 23 2024, 5:15 PM

	Unknown Object (File)
	Sep 17 2024, 7:51 AM

	Unknown Object (File)
	Sep 12 2024, 6:45 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7152: Improve inviting new users to a Phacility instance
T1139: Internationalize Phabricator

Commits

Restricted Diffusion Commit
rPd4680a7e4e84: Update Phabricator to work with more modular translations

Summary

Ref T7152. Ref T1139. This updates Phabricator so third-party libraries can translate their own stuff. Also:

Hide "All Caps" when not in development mode, since some users have found this a little confusing.
With other changes, adds a "Raw Strings" mode (development mode only).
Add an example silly translation to make sure the serious business flag works.
Add a basic British English translation.
Simplify handling of translation overrides.

Test Plan

Flipped serious business / development on and off and saw silly/development translations drop off.
Switched to "All Caps" and saw all caps.
Switched to Very English, Wow!
Switched to British english and saw "colour".

Diff Detail

Repository

Branch

xlation3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/settings/panel/PhabricatorAccountSettingsPanel.php:85	XHP16	TODO Comment
Advice	src/infrastructure/env/PhabricatorEnv.php:127	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 4465
Build 4479: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28314.Feb 11 2015, 8:23 PM

epriestley retitled this revision from to Update Phabricator to work with more modular translations.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T1139: Internationalize Phabricator, T7152: Improve inviting new users to a Phacility instance.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 11 2015, 8:23 PM

btrahan accepted this revision.Feb 11 2015, 8:29 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 11 2015, 8:29 PM

Remove translation.provider.
Update documentation a bit.

Caught one misspelling in a comment.

Closed by commit rPd4680a7e4e84: Update Phabricator to work with more modular translations (authored by epriestley, committed by epriestley). · Explain WhyFeb 11 2015, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

13 lines

applications/

base/

controller/

PhabricatorController.php

10 lines

config/

check/

PhabricatorExtraConfigSetupCheck.php

3 lines

option/

PhabricatorTranslationsConfigOptions.php

13 lines

people/

storage/

PhabricatorUser.php

13 lines

settings/

panel/

PhabricatorAccountSettingsPanel.php

28 lines

docs/

contributor/

internationalization.diviner

39 lines

infrastructure/

env/

PhabricatorEnv.php

33 lines

internationalization/

translation/

PhabricatorAllCapsTranslation.php

PhabricatorBaseEnglishTranslation.php

PhabricatorBritishEnglishTranslation.php

31 lines

PhabricatorEnglishTranslation.php

PhabricatorTranslation.php

	PhabricatorUSEnglishTranslation.php
	PhabricatorBaseEnglishTranslation.php

10 lines

PhabricatorVeryWowEnglishTranslation.php

22 lines

Diff 28315

src/__phutil_library_map__.php

Loading...

src/applications/base/controller/PhabricatorController.php

Loading...

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...

src/applications/config/option/PhabricatorTranslationsConfigOptions.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...

src/applications/settings/panel/PhabricatorAccountSettingsPanel.php

Loading...

src/docs/contributor/internationalization.diviner

Loading...

src/infrastructure/env/PhabricatorEnv.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorAllCapsTranslation.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorEnglishTranslation.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorTranslation.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorVeryWowEnglishTranslation.php

Loading...