HomePhabricator

Support invites in the registration and login flow

Tags
None
Referenced Files
F291494: Screen_Shot_2015-02-10_at_2.16.01_PM.png
Feb 11 2015, 2:06 PM
F291499: Screen_Shot_2015-02-10_at_2.15.12_PM.png
Feb 11 2015, 2:06 PM
F291497: Screen_Shot_2015-02-10_at_2.15.45_PM.png
Feb 11 2015, 2:06 PM
F291495: Screen_Shot_2015-02-10_at_2.16.09_PM.png
Feb 11 2015, 2:06 PM
F291493: Screen_Shot_2015-02-10_at_2.19.03_PM.png
Feb 11 2015, 2:06 PM
F291498: Screen_Shot_2015-02-10_at_2.15.36_PM.png
Feb 11 2015, 2:06 PM
F291496: Screen_Shot_2015-02-10_at_2.16.18_PM.png
Feb 11 2015, 2:06 PM
Subscribers
None

Description

Support invites in the registration and login flow

Summary:
Ref T7152. This substantially completes the upstream login flow. Basically, we just cookie you and push you through normal registration, with slight changes:

  • All providers allow registration if you have an invite.
  • Most providers get minor text changes to say "Register" instead of "Login" or "Login or Register".
  • The Username/Password provider changes to just a "choose a username" form.
  • We show the user that they're accepting an invite, and who invited them.

Then on actual registration:

  • Accepting an invite auto-verifies the address.
  • Accepting an invite auto-approves the account.
  • Your email is set to the invite email and locked.
  • Invites get to reassign nonprimary, unverified addresses from other accounts.

But 98% of the code is the same.

Test Plan:

  • Accepted an invite.
  • Verified a new address on an existing account via invite.
  • Followed a bad invite link.
  • Tried to accept a verified invite.
  • Reassigned an email by accepting an unverified, nonprimary invite on a new account.
  • Verified that reassigns appear in the activity log.

Screen_Shot_2015-02-10_at_2.19.03_PM.png (659×1 px, 158 KB)

Screen_Shot_2015-02-10_at_2.16.01_PM.png (738×1 px, 126 KB)

Screen_Shot_2015-02-10_at_2.16.09_PM.png (738×1 px, 142 KB)

Screen_Shot_2015-02-10_at_2.16.18_PM.png (1×1 px, 159 KB)

Screen_Shot_2015-02-10_at_2.15.45_PM.png (644×1 px, 109 KB)

Screen_Shot_2015-02-10_at_2.15.36_PM.png (633×1 px, 108 KB)

Screen_Shot_2015-02-10_at_2.15.12_PM.png (633×1 px, 109 KB)

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7152

Differential Revision: https://secure.phabricator.com/D11737

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Feb 11 2015, 2:06 PM
Reviewer
btrahan
Differential Revision
D11737: Support invites in the registration and login flow
Parents
rP6f90fbdef806: Send emails for email invites
Branches
Unknown
Tags
Unknown
Tasks
T7152: Improve inviting new users to a Phacility instance