Page MenuHomePhabricator
Differential D11747

Update Phabricator to work with more modular translations
ClosedPublic
Actions

Authored by epriestley on Feb 11 2015, 8:23 PM.
Tags
None
Referenced Files
F14070651: D11747.diff
Wed, Nov 20, 1:34 PM
F14048316: D11747.id28316.diff
Thu, Nov 14, 7:27 AM
F13995745: D11747.id28322.diff
Wed, Oct 23, 3:08 PM
F13962218: D11747.id28316.diff
Oct 15 2024, 8:52 AM
Unknown Object (File)
Oct 1 2024, 2:17 PM
Unknown Object (File)
Sep 23 2024, 5:15 PM
Unknown Object (File)
Sep 17 2024, 7:51 AM
Unknown Object (File)
Sep 12 2024, 6:45 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7152: Improve inviting new users to a Phacility instance
T1139: Internationalize Phabricator
Commits
Restricted Diffusion Commit
rPd4680a7e4e84: Update Phabricator to work with more modular translations
Summary

Ref T7152. Ref T1139. This updates Phabricator so third-party libraries can translate their own stuff. Also:

  • Hide "All Caps" when not in development mode, since some users have found this a little confusing.
  • With other changes, adds a "Raw Strings" mode (development mode only).
  • Add an example silly translation to make sure the serious business flag works.
  • Add a basic British English translation.
  • Simplify handling of translation overrides.
Test Plan
  • Flipped serious business / development on and off and saw silly/development translations drop off.
  • Switched to "All Caps" and saw all caps.
  • Switched to Very English, Wow!
  • Switched to British english and saw "colour".

Diff Detail

Repository
rP Phabricator
Branch
xlation3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/settings/panel/PhabricatorAccountSettingsPanel.php:85XHP16TODO Comment
Advicesrc/infrastructure/env/PhabricatorEnv.php:127XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 4464
Build 4478: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28314.Feb 11 2015, 8:23 PM
epriestley retitled this revision from to Update Phabricator to work with more modular translations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T1139: Internationalize Phabricator, T7152: Improve inviting new users to a Phacility instance.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 11 2015, 8:23 PM
btrahan accepted this revision.Feb 11 2015, 8:29 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2015, 8:29 PM
epriestley updated this revision to Diff 28315.Feb 11 2015, 8:30 PM
epriestley edited edge metadata.
  • Remove translation.provider.
  • Update documentation a bit.
epriestley updated this revision to Diff 28316.Feb 11 2015, 8:32 PM
  • Caught one misspelling in a comment.
Closed by commit rPd4680a7e4e84: Update Phabricator to work with more modular translations (authored by epriestley, committed by epriestley). · Explain WhyFeb 11 2015, 9:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28314

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/settings/panel/PhabricatorAccountSettingsPanel.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorAllCapsTranslation.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorEnglishTranslation.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorTranslation.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorVeryWowEnglishTranslation.php

Loading...
Phabricator · Built by Phacility