Page MenuHomePhabricator
Differential D11673

Rename `ComprehensiveLintEngine` class for consistency
ClosedPublic
Actions

Authored by joshuaspence on Feb 4 2015, 7:17 AM.
Tags
None
Referenced Files
F15426351: D11673.diff
Sun, Mar 23, 8:07 AM
F15396993: D11673.id28105.diff
Sun, Mar 16, 5:28 PM
F15386106: D11673.diff
Sat, Mar 15, 12:03 AM
F15384658: D11673.id28216.diff
Fri, Mar 14, 8:30 PM
F15383402: D11673.id28105.diff
Fri, Mar 14, 4:34 PM
F15292266: D11673.diff
Wed, Mar 5, 2:01 AM
Unknown Object (File)
Fri, Feb 28, 9:24 PM
Unknown Object (File)
Fri, Feb 28, 9:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
rARCb32cce79b2c7: Rename `ComprehensiveLintEngine` class for consistency
Summary

Ref T5655.

Test Plan

Ran arc lint with lint.engine set to ComprehensiveLintEngine and saw a deprecation notice.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28092.Feb 4 2015, 7:17 AM
joshuaspence retitled this revision from to Rename `ComprehensiveLintEngine` class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a task: T5655: Standardize naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 4 2015, 7:17 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 28105.Feb 4 2015, 8:27 PM
joshuaspence edited edge metadata.

Minor change

joshuaspence edited the test plan for this revision. (Show Details)Feb 4 2015, 8:27 PM
joshuaspence added a reviewer: epriestley.
joshuaspence retitled this revision from Rename `ComprehensiveLintEngine` class to Rename `ComprehensiveLintEngine` class for consistency.
epriestley accepted this revision.Feb 9 2015, 2:44 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 9 2015, 2:44 PM
Closed by commit rARCb32cce79b2c7: Rename `ComprehensiveLintEngine` class for consistency (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 9 2015, 7:58 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D11740: Remove deprecated `ComprehensiveLintEngine` class.Feb 11 2015, 7:46 AM
joshuaspence mentioned this in rARC92713cf9220c: Remove deprecated `ComprehensiveLintEngine` class.Apr 6 2015, 9:23 PM

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
engine/
ArcanistComprehensiveLintEngine.php
ComprehensiveLintEngine.php
4 lines
52 lines

Diff 28216

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/engine/ArcanistComprehensiveLintEngine.php

Loading...
View Options

src/lint/engine/ComprehensiveLintEngine.php

Loading...
Phabricator · Built by Phacility