Build XHPAST earlier in the stack
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 8:53 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUb2806977f6aa: Build XHPAST earlier in the stack

Summary

Currently, the PhutilLibraryMapBuilder will fail in an obscure way if the XHPAST binary is not built. The issue is that phutil_symbols.php will attempt to build the XHPAST binary, and this will happen eight times concurrently. Ultimately, this will fail with:

<libphutil>/scripts/build_xhpast.sh: line 24: ./xhpast: Text file busy

Test Plan

See D11528.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27981.Feb 2 2015, 8:53 PM

joshuaspence retitled this revision from to Build XHPAST earlier in the stack.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 8:53 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D11528: Allow `ArcanistPhutilLibraryLinter` to run with an out-of-date XHPAST binary.Feb 2 2015, 8:53 PM

epriestley accepted this revision.Feb 2 2015, 8:54 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 2 2015, 8:54 PM

Closed by commit rPHUb2806977f6aa: Build XHPAST earlier in the stack (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 8:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilLibraryMapBuilder.php

8 lines

Diff 27982

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Build XHPAST earlier in the stackClosedPublicActions