Paths

Table of Contentst

Differential D11613

Use `PhutilXHPASTBinary` methods
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 10:13 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC70f9b5d3aed7: Use `PhutilXHPASTBinary` methods

Summary

Use PhutilXHPASTBinary methods instead of xhpast_parse functions. Depends on D11517.

Test Plan

N/A, this is a direct swap.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4233
Build 4246: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27948.Feb 2 2015, 10:13 AM

joshuaspence retitled this revision from to Use `PhutilXHPASTBinary` methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D11517: Create a PHP wrapper class for the XHPAST binary.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 10:13 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Feb 2 2015, 1:56 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 2 2015, 1:56 PM

joshuaspence updated this object.Feb 2 2015, 7:58 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

Closed by commit rARC70f9b5d3aed7: Use `PhutilXHPASTBinary` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 7:58 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a child revision: D11615: Remove `xhpast_parse` methods.Feb 2 2015, 8:00 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistBaseXHPASTLinter.php

3 lines

Diff 27948

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

Use `PhutilXHPASTBinary` methodsClosedPublicActions