Improve atomizing of PHP `@return` annotation
ClosedPublic
Actions

Authored by joshuaspence on Jan 22 2015, 8:04 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6890: Diviner stops reading return type after <whitespace>

Commits

Restricted Diffusion Commit
rP7bd2994c2e21: Improve atomizing of PHP `@return` annotation

Summary

Fixes T6890. This doesn't feel like a perfect solution, but I can't think of any cases in which this will produce the wrong result either.

Test Plan

Ran ./bin/diviner generate and checked the generated documentation for PhabricatorCommonPasswords::loadWordlist(). The return type was corrected shown as map<string, bool>.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27565.Jan 22 2015, 8:04 PM

joshuaspence retitled this revision from to Improve atomizing of PHP `@return` annotation.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6890: Diviner stops reading return type after <whitespace>.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 22 2015, 8:04 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Yeah, this was my thought too. Feels sketchy, but I also couldn't come up with any cases where it produces the wrong behavior.

This revision is now accepted and ready to land.Jan 22 2015, 8:17 PM

Closed by commit rP7bd2994c2e21: Improve atomizing of PHP `@return` annotation (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 22 2015, 8:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

atomizer/

DivinerPHPAtomizer.php

2 lines

Diff 27572

View Options

src/applications/diviner/atomizer/DivinerPHPAtomizer.php

Improve atomizing of PHP `@return` annotationClosedPublicActions