Fixes T6890. This doesn't feel like a perfect solution, but I can't think of any cases in which this will produce the wrong result either.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T6890: Diviner stops reading return type after <whitespace>
- Commits
- Restricted Diffusion Commit
rP7bd2994c2e21: Improve atomizing of PHP `@return` annotation
Ran ./bin/diviner generate and checked the generated documentation for PhabricatorCommonPasswords::loadWordlist(). The return type was corrected shown as map<string, bool>.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3988 Build 4001: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Yeah, this was my thought too. Feels sketchy, but I also couldn't come up with any cases where it produces the wrong behavior.