Page MenuHomePhabricator

Improve atomizing of PHP `@return` annotation
ClosedPublic

Authored by joshuaspence on Jan 22 2015, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 24, 4:57 PM
Unknown Object (File)
Wed, Feb 7, 1:20 PM
Unknown Object (File)
Jan 27 2024, 6:12 PM
Unknown Object (File)
Jan 27 2024, 11:26 AM
Unknown Object (File)
Jan 26 2024, 6:01 PM
Unknown Object (File)
Dec 31 2023, 7:35 PM
Unknown Object (File)
Dec 27 2023, 8:23 PM
Unknown Object (File)
Dec 24 2023, 9:36 AM
Subscribers

Details

Summary

Fixes T6890. This doesn't feel like a perfect solution, but I can't think of any cases in which this will produce the wrong result either.

Test Plan

Ran ./bin/diviner generate and checked the generated documentation for PhabricatorCommonPasswords::loadWordlist(). The return type was corrected shown as map<string, bool>.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improve atomizing of PHP `@return` annotation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Yeah, this was my thought too. Feels sketchy, but I also couldn't come up with any cases where it produces the wrong behavior.

This revision is now accepted and ready to land.Jan 22 2015, 8:17 PM
This revision was automatically updated to reflect the committed changes.