Page MenuHomePhabricator

Don't create mentions for dependent diffs
ClosedPublic

Authored by joshuaspence on Jan 21 2015, 12:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 11, 7:21 AM
Unknown Object (File)
Jan 28 2024, 12:54 PM
Unknown Object (File)
Jan 26 2024, 6:01 PM
Unknown Object (File)
Jan 17 2024, 8:33 AM
Unknown Object (File)
Jan 12 2024, 5:21 AM
Unknown Object (File)
Jan 6 2024, 12:01 AM
Unknown Object (File)
Dec 3 2023, 9:31 AM
Unknown Object (File)
Nov 30 2023, 2:39 AM
Subscribers

Details

Summary

Fixes T6858. We shouldn't create mentions for dependent diffs.

NOTE: This won't fix the issue for existing revisions (which have the mentions edge), but I think that this is harmless.
Test Plan

Added Depends on Dxxx to a differential summary. Saw a josh added a dependent revision transaction, but no explicit mention.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't create mentions for dependent diffs.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2015, 8:11 PM
This revision was automatically updated to reflect the committed changes.