Don't use newInstanceWithoutConstructor in Arcanist unit test
ClosedPublic
Actions

Authored by epriestley on Jan 20 2015, 11:37 PM.

Details

Reviewers

hach-que
joshuaspence

Commits

rARC1cc8f3f377f6: Don't use newInstanceWithoutConstructor in Arcanist unit test

Summary

This requires PHP 5.4. Use newv() instead. I don't think the "without constructor" part is meaningful (or desirable). Simplify slightly.

Test Plan

arc unit --everything

Diff Detail

Repository

rARC Arcanist

Branch

versioncompat

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3951
Build 3964: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27525.Jan 20 2015, 11:37 PM

epriestley retitled this revision from to Don't use newInstanceWithoutConstructor in Arcanist unit test.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 20 2015, 11:37 PM

joshuaspence accepted this revision.Jan 20 2015, 11:38 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jan 20 2015, 11:38 PM

Closed by commit rARC1cc8f3f377f6: Don't use newInstanceWithoutConstructor in Arcanist unit test (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 11:39 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D11451: Use newInstance instead of newInstanceWithoutConstructor.Jan 20 2015, 11:39 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

ArcanistLinterTestCase.php

15 lines

Diff 27525

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

Don't use newInstanceWithoutConstructor in Arcanist unit testClosedPublicActions