Paths

Table of Contentst

Use newInstance instead of newInstanceWithoutConstructor
AbandonedPublic
Actions

Authored by hach-que on Jan 20 2015, 11:38 PM.

Tags

None

Referenced Files

	F18784960: D11451.id27526.diff
	Oct 13 2025, 3:58 PM

	F18777759: D11451.diff
	Oct 11 2025, 5:03 AM

	F18766040: D11451.diff
	Oct 7 2025, 2:37 PM

	F17735199: D11451.diff
	Jul 20 2025, 1:20 PM

	Unknown Object (File)
	May 19 2025, 1:36 PM

	Unknown Object (File)
	May 1 2025, 8:23 PM

	Unknown Object (File)
	Apr 30 2025, 10:14 AM

	Unknown Object (File)
	Apr 26 2025, 6:21 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

newInstanceWithoutConstructor is only supported on PHP 5.4.0 or higher. Changed to newInstance and all the tests pass on PHP 5.3.17.

Test Plan

Ran unit tests.

Diff Detail

Repository

rARC Arcanist

Branch

newInstancefix

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3952
Build 3965: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 27526.Jan 20 2015, 11:38 PM

hach-que retitled this revision from to Use newInstance instead of newInstanceWithoutConstructor.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 20 2015, 11:38 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

See D11450.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

ArcanistLinterTestCase.php

2 lines

Diff 27526

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

Use newInstance instead of newInstanceWithoutConstructorAbandonedPublicActions