Page MenuHomePhabricator

Use newInstance instead of newInstanceWithoutConstructor
AbandonedPublic

Authored by hach-que on Jan 20 2015, 11:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 12:07 PM
Unknown Object (File)
Sat, Feb 8, 1:25 AM
Unknown Object (File)
Sat, Feb 8, 1:25 AM
Unknown Object (File)
Sat, Feb 8, 1:25 AM
Unknown Object (File)
Wed, Feb 5, 1:17 PM
Unknown Object (File)
Tue, Feb 4, 2:08 AM
Unknown Object (File)
Thu, Jan 23, 10:21 PM
Unknown Object (File)
Thu, Jan 23, 10:21 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

newInstanceWithoutConstructor is only supported on PHP 5.4.0 or higher. Changed to newInstance and all the tests pass on PHP 5.3.17.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
newInstancefix
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3952
Build 3965: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Use newInstance instead of newInstanceWithoutConstructor.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.