Page MenuHomePhabricator
Differential D11450

Don't use newInstanceWithoutConstructor in Arcanist unit test
ClosedPublic
Actions

Authored by epriestley on Jan 20 2015, 11:37 PM.
Tags
None
Referenced Files
F19515812: D11450.diff
Wed, Jan 14, 4:10 PM
F19318185: D11450.id27525.diff
Thu, Dec 25, 6:27 AM
F18804456: D11450.id27527.diff
Oct 18 2025, 8:31 AM
F18787702: D11450.id27525.diff
Oct 15 2025, 1:02 AM
F18757191: D11450.id.diff
Oct 5 2025, 4:02 PM
F18426824: D11450.id27527.diff
Aug 30 2025, 11:19 PM
F18426087: D11450.id27527.diff
Aug 30 2025, 10:29 PM
F18406358: D11450.diff
Aug 30 2025, 12:08 AM
View All Files
Subscribers
epriestley

Details

Reviewers
hach-que
joshuaspence
Commits
rARC1cc8f3f377f6: Don't use newInstanceWithoutConstructor in Arcanist unit test
Summary

This requires PHP 5.4. Use newv() instead. I don't think the "without constructor" part is meaningful (or desirable). Simplify slightly.

Test Plan

arc unit --everything

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27525.Jan 20 2015, 11:37 PM
epriestley retitled this revision from to Don't use newInstanceWithoutConstructor in Arcanist unit test.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: hach-que, joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 20 2015, 11:37 PM
joshuaspence accepted this revision.Jan 20 2015, 11:38 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jan 20 2015, 11:38 PM
Closed by commit rARC1cc8f3f377f6: Don't use newInstanceWithoutConstructor in Arcanist unit test (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 11:39 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D11451: Use newInstance instead of newInstanceWithoutConstructor.Jan 20 2015, 11:39 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
15 lines

Diff 27527

View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
Phabricator · Built by Phacility