Page MenuHomePhabricator

Don't exit from the Aphlict Server prematurely
ClosedPublic

Authored by joshuaspence on Jan 19 2015, 11:00 AM.
Tags
None
Referenced Files
F13973866: D11426.diff
Fri, Oct 18, 3:05 AM
Unknown Object (File)
Sep 16 2024, 7:07 PM
Unknown Object (File)
Sep 15 2024, 12:27 PM
Unknown Object (File)
Sep 13 2024, 3:05 PM
Unknown Object (File)
Sep 13 2024, 3:04 PM
Unknown Object (File)
Sep 13 2024, 3:04 PM
Unknown Object (File)
Sep 13 2024, 3:04 PM
Unknown Object (File)
Aug 25 2024, 7:01 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2b12f6160213: Don't exit from the Aphlict Server prematurely
Summary

By calling process.exit(1) we are forcing the Node.js process to exit prematurely. Specifically, the process is terminated before the error is written to the log file. This can be verified by inspecting the value of debug._logs[0]._writableState.writing immediately before the process is terminated.

Test Plan

Ran ./bin/aphlict debug without the ws module being installed. Verified that <<< UNCAUGHT EXCEPTION! >>> was echoed to the console as well as the log file. Also verified that the exit status was non-zero.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3902
Build 3914: [Placeholder Plan] Wait for 30 Seconds