HomePhabricator

Don't exit from the Aphlict Server prematurely

Authored by joshuaspence.

Description

Don't exit from the Aphlict Server prematurely

Summary: By calling process.exit(1) we are forcing the Node.js process to exit prematurely. Specifically, the process is terminated before the error is written to the log file. This can be verified by inspecting the value of debug._logs[0]._writableState.writing immediately before the process is terminated.

Test Plan: Ran ./bin/aphlict debug without the ws module being installed. Verified that <<< UNCAUGHT EXCEPTION! >>> was echoed to the console as well as the log file. Also verified that the exit status was non-zero.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11426

Details

Committed
joshuaspenceJan 19 2015, 7:36 PM
Pushed
joshuaspenceJan 19 2015, 7:37 PM
Reviewer
Blessed Reviewers
Differential Revision
D11426: Don't exit from the Aphlict Server prematurely
Parents
rP3bc54c2041be: Project revamp part 2: Edit
Branches
Unknown
Tags
Unknown