Page MenuHomePhabricator

Clarify Aphlict settings
AbandonedPublic

Authored by joshuaspence on Jan 18 2015, 7:54 PM.
Tags
None
Referenced Files
F15533209: D11422.id27439.diff
Wed, Apr 23, 6:42 PM
F15529929: D11422.id28151.diff
Tue, Apr 22, 11:33 PM
F15523223: D11422.id27440.diff
Sun, Apr 20, 11:57 PM
F15521446: D11422.id27440.diff
Sun, Apr 20, 2:18 PM
F15517548: D11422.id.diff
Sat, Apr 19, 3:47 AM
F15516199: D11422.diff
Fri, Apr 18, 5:10 PM
F15490820: D11422.id27452.diff
Fri, Apr 11, 8:49 PM
F15486759: D11422.diff
Thu, Apr 10, 9:29 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Personally I find the notifications.client-uri and notifications.server-uri configuration options confusing, for the following reasons:

  1. The default values point to localhost, which is ambiguous in a multi-server setup.
  2. The protocol for notifications.client-uri is ignored, and ws or wss is used instead.
  3. "Server" is ambigious because the Aphlict server is actually composed of two separate server components (one HTTP server for receiving notifications and another WebSockets server for handling client connections).

As such, I have added to the existing documentation to clarify some of these ambiguities. Additionally, I have rename notifications.server-uri to notifications.admin-uri for clarity (even this name is still a little ambiguous, but feels slightly better).

Test Plan

Briefly tested the Aphlict functionality to make sure I hadn't missed anything.

Diff Detail

Repository
rP Phabricator
Branch
aphlict-clarify
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3891
Build 3903: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Clarify Aphlict settings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Improve documentation

resources/sql/autopatches/20150119.aphlictadmin.php
6–17 ↗(On Diff #27452)

Yeah, this doesn't actually work... I need a PhabricatorEnv::getEnvConfigExcludingDefault method but I can't seem to find such a method.