Page MenuHomePhabricator

Clarify Aphlict settings
AbandonedPublic

Authored by joshuaspence on Jan 18 2015, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 7:53 PM
Unknown Object (File)
Mon, Dec 9, 1:07 PM
Unknown Object (File)
Sat, Dec 7, 10:47 PM
Unknown Object (File)
Thu, Dec 5, 11:24 AM
Unknown Object (File)
Tue, Dec 3, 6:48 AM
Unknown Object (File)
Dec 1 2024, 3:32 AM
Unknown Object (File)
Nov 26 2024, 8:29 PM
Unknown Object (File)
Nov 23 2024, 6:11 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Personally I find the notifications.client-uri and notifications.server-uri configuration options confusing, for the following reasons:

  1. The default values point to localhost, which is ambiguous in a multi-server setup.
  2. The protocol for notifications.client-uri is ignored, and ws or wss is used instead.
  3. "Server" is ambigious because the Aphlict server is actually composed of two separate server components (one HTTP server for receiving notifications and another WebSockets server for handling client connections).

As such, I have added to the existing documentation to clarify some of these ambiguities. Additionally, I have rename notifications.server-uri to notifications.admin-uri for clarity (even this name is still a little ambiguous, but feels slightly better).

Test Plan

Briefly tested the Aphlict functionality to make sure I hadn't missed anything.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4361
Build 4374: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Clarify Aphlict settings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Improve documentation

resources/sql/autopatches/20150119.aphlictadmin.php
7–18

Yeah, this doesn't actually work... I need a PhabricatorEnv::getEnvConfigExcludingDefault method but I can't seem to find such a method.