Differential D11414

Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 8:14 PM.

Tags

None

Referenced Files

	F15426383: D11414.id27419.diff
	Sun, Mar 23, 8:22 AM

	F15421090: D11414.id.diff
	Fri, Mar 21, 8:57 PM

	F15419732: D11414.id27419.diff
	Fri, Mar 21, 8:28 AM

	F15416113: D11414.id27415.diff
	Thu, Mar 20, 9:20 AM

	F15414470: D11414.diff
	Thu, Mar 20, 12:46 AM

	F15407383: D11414.diff
	Tue, Mar 18, 5:21 PM

	F15396844: D11414.id27415.diff
	Sun, Mar 16, 4:36 PM

	Unknown Object (File)
	Feb 19 2025, 4:15 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

rARC8173ea3eea73: Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method

Summary

Ref T6822.

Test Plan

All the cool linters are doing it.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 3876
Build 3888: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	296 ms	ArcanistXMLLinterTestCase::testLinter
	528 ms	ArcanistCSSLintLinterTestCase::testLinter
	183 ms	ArcanistCSSLintLinterTestCase::testVersion
	131 ms	ArcanistChmodLinterTestCase::testLinter
	221 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 38 Passed · 12 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 27415.Jan 15 2015, 8:14 PM

joshuaspence retitled this revision from to Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 8:14 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2015, 8:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 8:34 PM

Closed by commit rARC8173ea3eea73: Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhpcsLinter.php

2 lines

Diff 27415

src/lint/linter/ArcanistPhpcsLinter.php

Loading...