Paths

Table of Contentst

Differential D11406

Fix visibility of the `PhabricatorWorker::doWork()` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:30 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

Restricted Diffusion Commit
rP94b96ae53319: Fix visibility of the `PhabricatorWorker::doWork()` methods

Summary

Ref T6822. This method is only called from within the PhabricatorWorker::executeTask() and PhabricatorWorker::scheduleTask() methods.

Test Plan

grepped for ->doWork.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27397.Jan 15 2015, 12:30 PM

joshuaspence retitled this revision from to Fix visibility of the `PhabricatorWorker::doWork()` methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:30 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2015, 2:21 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 2:21 PM

Closed by commit rP94b96ae53319: Fix visibility of the `PhabricatorWorker::doWork()` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

worker/

HarbormasterBuildWorker.php

2 lines

HarbormasterTargetWorker.php

2 lines

metamta/

PhabricatorMetaMTAWorker.php

2 lines

repository/

worker/

PhabricatorRepositoryCommitParserWorker.php

2 lines

PhabricatorRepositoryPushMailWorker.php

2 lines

search/

worker/

PhabricatorSearchWorker.php

2 lines

infrastructure/

sms/

worker/

PhabricatorSMSDemultiplexWorker.php

2 lines

PhabricatorSMSSendWorker.php

2 lines

Diff 27413

View Options

src/applications/harbormaster/worker/HarbormasterBuildWorker.php

View Options

src/applications/harbormaster/worker/HarbormasterTargetWorker.php

View Options

src/applications/metamta/PhabricatorMetaMTAWorker.php

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

View Options

src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php

View Options

src/applications/search/worker/PhabricatorSearchWorker.php

View Options

src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php

View Options

src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php

Fix visibility of the `PhabricatorWorker::doWork()` methodsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27413

src/applications/harbormaster/worker/HarbormasterBuildWorker.php

src/applications/harbormaster/worker/HarbormasterTargetWorker.php

src/applications/metamta/PhabricatorMetaMTAWorker.php

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php

src/applications/search/worker/PhabricatorSearchWorker.php

src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php

src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php

Fix visibility of the `PhabricatorWorker::doWork()` methods
ClosedPublic
Actions

Revision Contents
Changeset List