Page MenuHomePhabricator
Differential D11405

Fix the visibility of `PhutilDaemon::run` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:27 PM.
Tags
None
Referenced Files
F14494602: D11405.diff
Fri, Jan 3, 5:59 AM
Unknown Object (File)
Fri, Dec 13, 11:08 AM
Unknown Object (File)
Thu, Dec 5, 4:02 AM
Unknown Object (File)
Thu, Dec 5, 3:33 AM
Unknown Object (File)
Nov 27 2024, 1:25 PM
Unknown Object (File)
Nov 18 2024, 4:50 PM
Unknown Object (File)
Nov 8 2024, 9:22 PM
Unknown Object (File)
Nov 2 2024, 8:01 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP62dfcd1e552f: Fix the visibility of `PhutilDaemon::run` methods
Summary

Ref T6822. This method is only called from PhutilDaemon::execute() and can be made protected.

Test Plan

See D11404.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27396.Jan 15 2015, 12:27 PM
joshuaspence retitled this revision from to Fix the visibility of `PhutilDaemon::run` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:27 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 15 2015, 2:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 2:21 PM
Closed by commit rP62dfcd1e552f: Fix the visibility of `PhutilDaemon::run` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
fact/
daemon/
2 lines
repository/
daemon/
2 lines
infrastructure/
daemon/
bot/
2 lines
garbagecollector/
2 lines
workers/
2 lines

Diff 27412

View Options

src/applications/fact/daemon/PhabricatorFactDaemon.php

Loading...
View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/infrastructure/daemon/bot/PhabricatorBot.php

Loading...
View Options

src/infrastructure/daemon/garbagecollector/PhabricatorGarbageCollectorDaemon.php

Loading...
View Options

src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php

Loading...
Phabricator · Built by Phacility