Refactoring of the Aphlict server
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2015, 11:29 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP9a7ad972cd26: Refactoring of the Aphlict server

Summary

Tidy the Aphlict server by splitting the functionality into two main modules, AphlictClientServer and `AphlictAdminServer. There is still further tidying that could be done here, but I feel that this puts us in a much better place.

Test Plan

Sent notifications via /notification/status/.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27343.Jan 14 2015, 11:29 AM

joshuaspence retitled this revision from to Refactoring of the Aphlict server.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 14 2015, 11:29 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Yeah, this is nice. I do want to retain the ws warning, though.

support/aphlict/server/aphlict_server.js
72–75	I think it's important that we retain this error (and perform this check before the `config.test` early exit). The default error message is much less obvious.
117	Maybe give it the whole `client_server` instead of the listener list? This feels a little like it's handing a pile of guts to the admin server. Pretty nitpicky.