Tidy the Aphlict server by splitting the functionality into two main modules, AphlictClientServer and `AphlictAdminServer. There is still further tidying that could be done here, but I feel that this puts us in a much better place.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP9a7ad972cd26: Refactoring of the Aphlict server
Sent notifications via /notification/status/.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3833 Build 3845: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Yeah, this is nice. I do want to retain the ws warning, though.
| support/aphlict/server/aphlict_server.js | ||
|---|---|---|
| 72–75 | I think it's important that we retain this error (and perform this check before the config.test early exit). The default error message is much less obvious. | |
| 111 | Maybe give it the whole client_server instead of the listener list? This feels a little like it's handing a pile of guts to the admin server. Pretty nitpicky. | |