Page MenuHomePhabricator

Refactoring of the Aphlict server
ClosedPublic

Authored by joshuaspence on Jan 14 2015, 11:29 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP9a7ad972cd26: Refactoring of the Aphlict server
Summary

Tidy the Aphlict server by splitting the functionality into two main modules, AphlictClientServer and `AphlictAdminServer. There is still further tidying that could be done here, but I feel that this puts us in a much better place.

Test Plan

Sent notifications via /notification/status/.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence retitled this revision from to Refactoring of the Aphlict server.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley requested changes to this revision.Jan 14 2015, 1:44 PM
epriestley edited edge metadata.

Yeah, this is nice. I do want to retain the ws warning, though.

support/aphlict/server/aphlict_server.js
72–75

I think it's important that we retain this error (and perform this check before the config.test early exit). The default error message is much less obvious.

117

Maybe give it the whole client_server instead of the listener list? This feels a little like it's handing a pile of guts to the admin server. Pretty nitpicky.

This revision now requires changes to proceed.Jan 14 2015, 1:44 PM
joshuaspence edited edge metadata.

Changes as suggested

epriestley accepted this revision.Jan 15 2015, 2:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 2:14 PM
This revision was automatically updated to reflect the committed changes.