Page MenuHomePhabricator
Differential D11364

Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision`
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 11:33 AM.
Tags
None
Referenced Files
F15466867: D11364.diff
Thu, Apr 3, 10:27 AM
F15415484: D11364.id27297.diff
Thu, Mar 20, 6:12 AM
F15414560: D11364.diff
Thu, Mar 20, 1:11 AM
F15391057: D11364.id27297.diff
Sat, Mar 15, 8:02 AM
Unknown Object (File)
Feb 8 2025, 1:06 AM
Unknown Object (File)
Feb 8 2025, 1:06 AM
Unknown Object (File)
Feb 8 2025, 1:06 AM
Unknown Object (File)
Feb 8 2025, 1:06 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP346d9707075a: Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision`
Summary

Ref T6822.

Test Plan

grep for ->readValueFromRevision(.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3809
Build 3821: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27297.Jan 13 2015, 11:33 AM
joshuaspence retitled this revision from to Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 11:33 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 13 2015, 1:35 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2015, 1:35 PM
Closed by commit rP346d9707075a: Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 8:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
2 lines

Diff 27297

View Options

src/applications/differential/customfield/DifferentialManiphestTasksField.php

Loading...
Phabricator · Built by Phacility