Page MenuHomePhabricator

Fix a possible segfault when parsing JSON containing very large strings
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 10:29 AM.
Tags
None
Referenced Files
F13995374: D11323.id27194.diff
Wed, Oct 23, 12:27 PM
Unknown Object (File)
Oct 1 2024, 3:03 PM
Unknown Object (File)
Oct 1 2024, 8:00 AM
Unknown Object (File)
Sep 23 2024, 7:24 PM
Unknown Object (File)
Sep 10 2024, 4:52 AM
Unknown Object (File)
Sep 4 2024, 12:58 PM
Unknown Object (File)
Aug 25 2024, 10:47 PM
Unknown Object (File)
Aug 25 2024, 1:13 PM
Subscribers

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix a possible segfault when parsing JSON containing very large strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I think that even with (?:...) we can blow the stack -- see phutil_is_utf8_slowly() -- but the limits are high enough to be reasonable.

This revision is now accepted and ready to land.Jan 11 2015, 5:01 PM
This revision was automatically updated to reflect the committed changes.