Page MenuHomePhabricator

Cache the version for external linters
AbandonedPublic

Authored by joshuaspence on Jan 11 2015, 5:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 10:14 AM
Unknown Object (File)
Thu, Dec 19, 8:55 PM
Unknown Object (File)
Wed, Dec 18, 10:56 PM
Unknown Object (File)
Sat, Dec 14, 9:04 AM
Unknown Object (File)
Dec 12 2024, 10:08 PM
Unknown Object (File)
Dec 8 2024, 11:07 PM
Unknown Object (File)
Dec 6 2024, 9:47 PM
Unknown Object (File)
Nov 30 2024, 11:30 PM
Subscribers

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Summary

Currently there are no safeguards in place to prevent us from making lots of calls to $EXTERNAL_LINTER --version (which is a relatively slow operation). Instead, we can provide a simple cacheing mechanism (using a static variable) in ArcanistExternalLinter. This mainly affects the unit tests of rARC, but there may be other situations in which this will yield performance improvements.

Test Plan

Before

> time ./bin/arc unit -- src/lint/linter
real    0m38.472s
user    0m35.614s
sys 0m3.536s

After

> time ./bin/arc unit -- src/lint/linter
real    0m27.364s
user    0m25.601s
sys 0m2.338s

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3864
Build 3876: [Placeholder Plan] Wait for 30 Seconds