Page MenuHomePhabricator

Cache the version for external linters
AbandonedPublic

Authored by joshuaspence on Jan 11 2015, 5:57 AM.
Tags
None
Referenced Files
F22593288: D11315.diff
Mon, Sep 28, 8:44 AM
Unknown Object (File)
Jun 22 2026, 3:51 PM
Unknown Object (File)
Jun 6 2026, 2:41 AM
Unknown Object (File)
Mar 31 2026, 8:39 PM
Unknown Object (File)
Mar 31 2026, 6:32 PM
Unknown Object (File)
Mar 11 2026, 1:46 PM
Unknown Object (File)
Mar 11 2026, 7:56 AM
Unknown Object (File)
Mar 11 2026, 2:47 AM
Subscribers

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Summary

Currently there are no safeguards in place to prevent us from making lots of calls to $EXTERNAL_LINTER --version (which is a relatively slow operation). Instead, we can provide a simple cacheing mechanism (using a static variable) in ArcanistExternalLinter. This mainly affects the unit tests of rARC, but there may be other situations in which this will yield performance improvements.

Test Plan

Before

> time ./bin/arc unit -- src/lint/linter
real    0m38.472s
user    0m35.614s
sys 0m3.536s

After

> time ./bin/arc unit -- src/lint/linter
real    0m27.364s
user    0m25.601s
sys 0m2.338s

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3864
Build 3876: [Placeholder Plan] Wait for 30 Seconds