Page MenuHomePhabricator
Differential D11285

Stop advising users to use `npm -g` to install websockets
ClosedPublic
Actions

Authored by epriestley on Jan 8 2015, 9:58 PM.
Tags
None
Referenced Files
F14091799: D11285.diff
Mon, Nov 25, 2:22 AM
Unknown Object (File)
Sat, Nov 23, 10:53 AM
Unknown Object (File)
Fri, Nov 22, 10:46 PM
Unknown Object (File)
Fri, Nov 22, 10:46 PM
Unknown Object (File)
Fri, Nov 22, 10:45 PM
Unknown Object (File)
Fri, Nov 22, 10:43 PM
Unknown Object (File)
Fri, Nov 22, 10:21 PM
Unknown Object (File)
Wed, Nov 20, 6:06 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
chad
richardvanvelzen
Maniphest Tasks
T6910: Notification docs wrongly specify global installation as recommendation
Commits
Restricted Diffusion Commit
rPf0ade1be1c57: Stop advising users to use `npm -g` to install websockets
Summary

Fixes T6910. This advice is bad, doesn't work, and was based on me havng an outdated or incorrect understanding of Node and npm.

Test Plan

Read documentation.

Diff Detail

Repository
rP Phabricator
Branch
npmg
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3697
Build 3707: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27114.Jan 8 2015, 9:58 PM
epriestley retitled this revision from to Stop advising users to use `npm -g` to install websockets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, richardvanvelzen, btrahan.
epriestley added a task: T6910: Notification docs wrongly specify global installation as recommendation.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 8 2015, 9:58 PM
joshuaspence accepted this revision.Jan 8 2015, 10:00 PM
joshuaspence edited edge metadata.
joshuaspence added inline comments.
src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
105

Don't steal my thunder man, see D11284.

This revision is now accepted and ready to land.Jan 8 2015, 10:00 PM
chad accepted this revision.Jan 8 2015, 10:00 PM
chad added a reviewer: chad.
epriestley updated this revision to Diff 27115.Jan 8 2015, 10:01 PM
epriestley edited edge metadata.
  • Don't steal thunder.
Closed by commit rPf0ade1be1c57: Stop advising users to use `npm -g` to install websockets (authored by epriestley, committed by epriestley). · Explain WhyJan 8 2015, 10:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
aphlict/
management/
1 line
docs/
user/
configuration/
12 lines
support/
aphlict/
server/
3 lines

Diff 27114

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
View Options

src/docs/user/configuration/notifications.diviner

Loading...
View Options

support/aphlict/server/aphlict_server.js

Loading...
Phabricator · Built by Phacility