Stop advising users to use `npm -g` to install websockets
ClosedPublic
Actions

Authored by epriestley on Jan 8 2015, 9:58 PM.

Details

Reviewers

joshuaspence
btrahan
chad
richardvanvelzen

Maniphest Tasks

T6910: Notification docs wrongly specify global installation as recommendation

Commits

Restricted Diffusion Commit
rPf0ade1be1c57: Stop advising users to use `npm -g` to install websockets

Summary

Fixes T6910. This advice is bad, doesn't work, and was based on me havng an outdated or incorrect understanding of Node and npm.

Test Plan

Read documentation.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27114.Jan 8 2015, 9:58 PM

epriestley retitled this revision from to Stop advising users to use `npm -g` to install websockets.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, richardvanvelzen, btrahan.

epriestley added a task: T6910: Notification docs wrongly specify global installation as recommendation.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 8 2015, 9:58 PM

joshuaspence accepted this revision.Jan 8 2015, 10:00 PM

joshuaspence edited edge metadata.

joshuaspence added inline comments.

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
105 ↗	(On Diff #27114)	Don't steal my thunder man, see D11284.

This revision is now accepted and ready to land.Jan 8 2015, 10:00 PM

chad accepted this revision.Jan 8 2015, 10:00 PM

chad added a reviewer: chad.

Don't steal thunder.

Closed by commit rPf0ade1be1c57: Stop advising users to use `npm -g` to install websockets (authored by epriestley, committed by epriestley). · Explain WhyJan 8 2015, 10:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

docs/

user/

configuration/

notifications.diviner

12 lines

support/

aphlict/

server/

aphlict_server.js

3 lines

Diff 27118

View Options

src/docs/user/configuration/notifications.diviner