Page MenuHomePhabricator

Make race condition window for Conpherence smaller and rarer
ClosedPublic

Authored by epriestley on Jan 8 2015, 8:38 AM.

Details

Summary

Ref T6713. This isn't very clean, and primarily unblocks D11143.

After D11143, I have a reliable local race where I submit, get a notification immediately, then get a double update (form submission + notification-triggered update).

Instead, make the notification updates wait for form submissions.

This doesn't resolve the race completely. The notification updates don't block chat submission (only the other way around), so if you're really fast you can submit at the same time someone else sends chat and race. But this fixes the most glaring issue.

The overall structure here is still pretty shaky but I tried to improve things a little, at least.

Test Plan

Chatted with myself, saw 0 races instead of 100% races.

Diff Detail

Repository
rP Phabricator
Branch
websockets4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3681
Build 3691: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make race condition window for Conpherence smaller and rarer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
joshuaspence edited edge metadata.

Sure, why not

This revision is now accepted and ready to land.Jan 8 2015, 9:07 AM
This revision was automatically updated to reflect the committed changes.