Page MenuHomePhabricator
Differential D11267

Improvements to `LINT_IMPLICIT_VISIBILITY`
ClosedPublic
Actions

Authored by joshuaspence on Jan 7 2015, 1:26 PM.
Tags
None
Referenced Files
F14120078: D11267.diff
Fri, Nov 29, 7:13 AM
Unknown Object (File)
Thu, Nov 21, 3:42 PM
Unknown Object (File)
Sat, Nov 16, 6:16 PM
Unknown Object (File)
Sat, Nov 9, 11:39 PM
Unknown Object (File)
Sat, Nov 9, 10:36 PM
Unknown Object (File)
Oct 18 2024, 10:08 AM
Unknown Object (File)
Oct 9 2024, 2:04 PM
Unknown Object (File)
Oct 9 2024, 2:04 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
richardvanvelzen
Group Reviewers
Blessed Reviewers
Commits
rARCa232f7d5b874: Improvements to `LINT_IMPLICIT_VISIBILITY`
Summary

See D10687#104589.

Test Plan

Wrote unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3663
Build 3673: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27066.Jan 7 2015, 1:26 PM
joshuaspence retitled this revision from to Improvements to `LINT_IMPLICIT_VISIBILITY`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, richardvanvelzen.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 7 2015, 1:26 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
richardvanvelzen accepted this revision.Jan 7 2015, 2:15 PM
richardvanvelzen edited edge metadata.

Seems reasonable to me.

One minor question - should it be:

  1. static public function or public static function
  2. abstract public function or public abstract function

?
For 1. I prefer the latter, while for 2. I prefer the former.

However, I don't care either way. This looks fine.

epriestley edited edge metadata.Jan 7 2015, 2:20 PM

I think we use public static (vs static public) and abstract public (vs public abstract) nearly 100% of the time, although leaving the order undefined also seems fine to me.

epriestley accepted this revision.Jan 7 2015, 2:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 7 2015, 2:20 PM
joshuaspence added a comment.Jan 7 2015, 7:36 PM

I actually have a lint rule coming up for LINT_MODIFIER_ORDERING.

Closed by commit rARCa232f7d5b874: Improvements to `LINT_IMPLICIT_VISIBILITY` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 7 2015, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
30 lines
__tests__/
xhpast/
9 lines

Diff 27066

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/implicit-visibility.lint-test

Loading...
Phabricator · Built by Phacility