Page MenuHomePhabricator

Remove direct calls to LowLevelCommitQuery
ClosedPublic

Authored by epriestley on Jan 6 2015, 5:25 PM.
Tags
None
Referenced Files
F18830385: D11253.diff
Sat, Oct 25, 6:38 AM
F18816490: D11253.id.diff
Tue, Oct 21, 7:15 AM
F18813568: D11253.diff
Mon, Oct 20, 5:29 PM
F18756785: D11253.id.diff
Sun, Oct 5, 1:29 PM
F18657196: D11253.id28280.diff
Sep 23 2025, 12:52 AM
F18644309: D11253.diff
Sep 19 2025, 4:50 AM
F18601850: D11253.id27008.diff
Sep 13 2025, 1:36 PM
F18598264: D11253.id.diff
Sep 13 2025, 4:41 AM
Subscribers

Details

Summary

Ref T2783. This cleans up some more of the direct VCS access calls. If the repository is local, this boils down to an in-process call. If not, it uses Conduit to make an intracluster request.

Test Plan

Used reparse.php --message <commit> --trace to observe cluster request.

Diff Detail

Repository
rP Phabricator
Branch
lowlevel2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3638
Build 3647: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove direct calls to LowLevelCommitQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Looks like the new parseCommitWithRef is never called?

Oh, man, yuck. I code review.

epriestley edited edge metadata.
  • Call subclasses correctly.
  • Ran real daemons on a real repo, saw them complete all parsing stages, for real.

This class tree is still a bit messy but I didn't want to go crazy with refactoring it.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 6:01 PM
This revision was automatically updated to reflect the committed changes.