Ref T2783. This cleans up some more of the direct VCS access calls. If the repository is local, this boils down to an in-process call. If not, it uses Conduit to make an intracluster request.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T2783: Make working-copy operations service-oriented
- Commits
- Restricted Diffusion Commit
rPbdd7a35b3094: Remove direct calls to LowLevelCommitQuery
Used reparse.php --message <commit> --trace to observe cluster request.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- lowlevel2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3636 Build 3645: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
- Call subclasses correctly.
- Ran real daemons on a real repo, saw them complete all parsing stages, for real.
Comment Actions
This class tree is still a bit messy but I didn't want to go crazy with refactoring it.