Page MenuHomePhabricator
Differential D11253

Remove direct calls to LowLevelCommitQuery
ClosedPublic
Actions

Authored by epriestley on Jan 6 2015, 5:25 PM.
Tags
None
Referenced Files
F13100046: D11253.id28280.diff
Fri, Apr 26, 4:36 PM
F13100045: D11253.id27011.diff
Fri, Apr 26, 4:35 PM
F13100043: D11253.id27008.diff
Fri, Apr 26, 4:35 PM
F13100040: D11253.id.diff
Fri, Apr 26, 4:35 PM
Unknown Object (File)
Thu, Apr 25, 1:17 PM
Unknown Object (File)
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Sun, Apr 21, 5:08 PM
Unknown Object (File)
Thu, Apr 11, 8:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2783: Make working-copy operations service-oriented
Commits
Restricted Diffusion Commit
rPbdd7a35b3094: Remove direct calls to LowLevelCommitQuery
Summary

Ref T2783. This cleans up some more of the direct VCS access calls. If the repository is local, this boils down to an in-process call. If not, it uses Conduit to make an intracluster request.

Test Plan

Used reparse.php --message <commit> --trace to observe cluster request.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27008.Jan 6 2015, 5:25 PM
epriestley retitled this revision from to Remove direct calls to LowLevelCommitQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2783: Make working-copy operations service-oriented.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 6 2015, 5:25 PM
btrahan edited edge metadata.Jan 6 2015, 5:55 PM

Looks like the new parseCommitWithRef is never called?

epriestley planned changes to this revision.Jan 6 2015, 5:57 PM

Oh, man, yuck. I code review.

btrahan added a comment.Jan 6 2015, 5:57 PM

Haha, the process works!

epriestley updated this revision to Diff 27011.Jan 6 2015, 6:00 PM
epriestley edited edge metadata.
  • Call subclasses correctly.
  • Ran real daemons on a real repo, saw them complete all parsing stages, for real.
epriestley added a comment.Jan 6 2015, 6:00 PM

This class tree is still a bit messy but I didn't want to go crazy with refactoring it.

btrahan accepted this revision.Jan 6 2015, 6:01 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 6:01 PM
Closed by commit rPbdd7a35b3094: Remove direct calls to LowLevelCommitQuery (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2015, 11:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28280

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility