Page MenuHomePhabricator
Differential D11249

Fix method visibility for `AphrontFormControl` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:58 AM.
Tags
None
Referenced Files
F18363003: D11249.diff
Wed, Aug 27, 3:23 PM
F18087887: D11249.diff
Wed, Aug 6, 6:03 AM
F18048284: D11249.id.diff
Sun, Aug 3, 1:28 PM
F18045941: D11249.id27025.diff
Sun, Aug 3, 10:06 AM
F17888672: D11249.id.diff
Tue, Jul 29, 2:23 AM
F17887074: D11249.diff
Tue, Jul 29, 1:27 AM
F17711698: D11249.diff
Jul 17 2025, 9:13 AM
Unknown Object (File)
May 21 2025, 3:29 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP7756484a000c: Fix method visibility for `AphrontFormControl` methods
Summary

Ref T6822.

Test Plan

Visual inspection. These methods are only called from within the AphrontFormControl class.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3629
Build 3638: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26995.Jan 6 2015, 10:58 AM
joshuaspence retitled this revision from to Fix method visibility for `AphrontFormControl` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:58 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:18 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:47 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:47 PM
Closed by commit rP7756484a000c: Fix method visibility for `AphrontFormControl` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
flag/
view/
4 lines
releeph/
view/
branch/
4 lines
request/
4 lines

Diff 26995

View Options

src/applications/flag/view/PhabricatorFlagSelectControl.php

Loading...
View Options

src/applications/releeph/view/branch/ReleephBranchPreviewView.php

Loading...
View Options

src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php

Loading...
Phabricator · Built by Phacility